Skip to content

ci: check that hack/core.sh is release-tools' xhandler/core.sh - #7

Closed
carlosthe19916 wants to merge 1 commit into
project-openubl:mainfrom
carlosthe19916:ci/verify-core-script
Closed

carlosthe19916 wants to merge 1 commit into
project-openubl:mainfrom
carlosthe19916:ci/verify-core-script

Conversation

@carlosthe19916

Copy link
Copy Markdown
Member

hack/core.sh was identical in the three libraries only by convention. release-tools now holds the original, in xhandler/core.sh (project-openubl/release-tools#24).

  • make verify-core-script: downloads the original and diffs this copy against it. CI runs it, so a copy that drifts fails with "change it there first, then copy it".
  • The copy: hack/core.sh gets the original's header, which points to release-tools.
  • CONTRIBUTING.md: explains it.

Merge release-tools#24 first. Until then, this check fails with a 404, then re-run CI. Tested against #24's branch: identical passes, a modified copy fails with a diff, and a missing original fails with the 404.

🤖 Generated with Claude Code

The three libraries' hack/core.sh were identical only by convention.
release-tools now holds the original (xhandler/core.sh); make
verify-core-script compares this copy with it and CI runs it, so a copy
that drifts fails.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@carlosthe19916

Copy link
Copy Markdown
Member Author

Superseded: core.sh moves to xhandler-rust (xhandler-wasm/core.sh), next to the release format it reads, and the libraries fetch it from the tag of the core they sync instead of keeping copies. See the follow-up PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant